commit dcbd9dbee05c46217c20e82d89b3c8390ce79b22
parent 75688a48d31df70891cbab365aa2461ff3187c5b
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Sat, 12 Sep 2026 12:10:41 -0400
plans: the S3 gate numbers after the three review fixes
common 1128 -> 1129, and the re-run e2e counts (export 172, hub 5,
export-search 19, zero failures). Also states why the bench was not
re-run: `git diff 1fe9bf1..HEAD -- mcp/` is empty, so the benchmarked
binary is byte-identical — F3 removed defaults mcp never took and F1 is
viewer-only.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Diffstat:
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/plans/one-core-phase-2.md b/plans/one-core-phase-2.md
@@ -529,9 +529,10 @@ mattered.
#### Gates
- `pnpm -r exec tsc --noEmit` — clean in all six packages, after every commit.
-- `pnpm --filter yt-dlp-transcript-common test` — **1128 passed / 0 failed**
- (baseline **1077** at `7f86aef`; + 2 `policy`, + 8 `window`, + 2 `rank`,
- + 6 `collapse`, + 21 `evalTree`, + 12 `leafPipeline` = 51; none lost).
+- `pnpm --filter yt-dlp-transcript-common test` — **1129 passed / 0 failed**
+ (baseline **1077** at `7f86aef`; + 3 `policy`/`window` width cases, + 8
+ `window`, + 2 `rank`, + 6 `collapse`, + 21 `evalTree`, + 12 `leafPipeline`
+ = 52; none lost).
The architecture test passes with `"components"` in `FORBIDDEN.lib` and the
ALLOWED ledger **byte-identical** to the base.
- `pnpm --filter yt-dlp-transcript-mcp test` — **205 passed / 0 failed**,
@@ -584,7 +585,15 @@ mattered.
- **e2e**, behind the queue lock from the worktree (port block
4000/4001/4010/4011/4020): export `e2e` **172 passed / 0 failed**,
`e2e:hub` **5 passed / 0 failed**, editor `export-search` +
- `export-player-platform-cache` **21 passed / 0 failed**.
+ `export-player-platform-cache` **21 passed / 0 failed**. Re-run after the
+ three review fixes (F1 touches `SearchSessionContext.tsx`): export
+ **172 passed**, hub **5 passed**, editor `export-search` **19 passed** —
+ all 0 failed.
+- The bench was **not** re-run after the review fixes, and does not need to be:
+ `git diff fb6a31d..HEAD -- mcp/` is empty, so the benchmarked binary is
+ byte-identical. F3 removed defaults that mcp never took (it passed
+ `policy.snippetChars` and `opts.maxLines ?? MCP_POLICY.windowLineCap`
+ explicitly at every site) and F1 is viewer-only.
- `e2e:2origin` was **not run**: it is red on the base for a reason outside this
slice (the hub `/ask` prerender — see S1's §Record, verified there against
`c7f7b90` itself). Because S3 touches two of the three files that failure
