commit d5a4ac2c3ddb2b043ee9d888558c2e74b5f508e2
parent 63dcce2d7579dc3bbc50a3ef382cd954eef41f23
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Sat, 26 Sep 2026 23:19:04 -0400
homepage: the footer's Elsewhere row drops the Ko-fi mark and renders only when there are social links again
Footer.tsx is back to its state before release 9 slice C1b byte for byte:
the column under "Elsewhere" is the operator's social icons, and a
homepage with none renders no column. public/kofi-symbol.svg is removed.
e2e: the Ko-fi mark test becomes one negative check, no link to ko-fi.com
anywhere on the home page.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Diffstat:
3 files changed, 23 insertions(+), 79 deletions(-)
diff --git a/homepage/app/components/Footer.tsx b/homepage/app/components/Footer.tsx
@@ -5,7 +5,6 @@ import {
} from "yt-dlp-transcript-common/lib/settings";
import { resolveHomepageSocialLinks } from "yt-dlp-transcript-common/lib/homepage";
import {
- KOFI_URL,
PROJECT_NAME,
PROJECT_TAGLINE,
} from "yt-dlp-transcript-common/lib/project";
@@ -50,49 +49,26 @@ export default function Footer() {
</ul>
</nav>
- {/* "Elsewhere": the operator's social accounts, then the project's
- Ko-fi — the official mark, last in the row, no copy (the operator's
- 2026-09-26 ruling: the mark in the social section everywhere; it
- replaced the bare text link of 2026-09-25). Ko-fi is always present,
- so the row always renders. The mark is the project's own vendored
- asset in Ko-fi's official colours (never through normalizeSocialSvg,
- which recolours operator icons to currentColor). */}
- <div className="flex flex-col gap-3">
- <span className="label-machine">Elsewhere</span>
- <ul className="flex items-center gap-4 list-none">
- {socialLinks.map((link, i) => (
- <li key={`${link.url}-${i}`}>
- <a
- href={link.url}
- title={link.label}
- aria-label={link.label}
- target="_blank"
- rel="noopener noreferrer"
- className="inline-block w-5 h-5 text-[var(--faint)] hover:text-[var(--foreground)] transition-colors [&_svg]:w-full [&_svg]:h-full"
- dangerouslySetInnerHTML={{ __html: sizeSocialSvg(link.svg) }}
- />
- </li>
- ))}
- <li>
- <a
- href={KOFI_URL}
- title="Ko-fi"
- aria-label="Ko-fi"
- target="_blank"
- rel="noopener noreferrer"
- className="inline-block w-5 h-5 transition-opacity hover:opacity-80"
- >
- <img
- src="/kofi-symbol.svg"
- alt=""
- width={20}
- height={20}
- className="w-full h-full"
- />
- </a>
- </li>
- </ul>
- </div>
+ {socialLinks.length > 0 && (
+ <div className="flex flex-col gap-3">
+ <span className="label-machine">Elsewhere</span>
+ <ul className="flex items-center gap-4 list-none">
+ {socialLinks.map((link, i) => (
+ <li key={`${link.url}-${i}`}>
+ <a
+ href={link.url}
+ title={link.label}
+ aria-label={link.label}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="inline-block w-5 h-5 text-[var(--faint)] hover:text-[var(--foreground)] transition-colors [&_svg]:w-full [&_svg]:h-full"
+ dangerouslySetInnerHTML={{ __html: sizeSocialSvg(link.svg) }}
+ />
+ </li>
+ ))}
+ </ul>
+ </div>
+ )}
</div>
</footer>
);
diff --git a/homepage/e2e/marketing.spec.ts b/homepage/e2e/marketing.spec.ts
@@ -1,7 +1,6 @@
import fs from "node:fs";
import path from "node:path";
import { test, expect } from "@playwright/test";
-import { KOFI_URL } from "../../common/lib/project";
// The home page's job is to say what Archilyzer is and offer the download.
// Nothing asserted here names a count, a site or a headline number. The numeric
@@ -126,27 +125,9 @@ test("the headings after the H1 are in Title Case", async ({ page }) => {
).toBeVisible();
});
-test("the footer's social row ends with the Ko-fi mark", async ({ page }) => {
- const footer = page.locator("footer");
- const kofi = footer.getByRole("link", { name: "Ko-fi", exact: true });
- await expect(kofi).toHaveCount(1);
- await expect(kofi).toHaveAttribute("href", KOFI_URL);
- await expect(kofi).toHaveAttribute("target", "_blank");
- await expect(kofi).toHaveAttribute("rel", "noopener noreferrer");
- // The mark, not copy: an image with an empty alt inside a link whose
- // accessible name is exactly "Ko-fi", and no visible text.
- await expect(kofi).toHaveText("");
- const img = kofi.locator("img");
- await expect(img).toHaveAttribute("src", "/kofi-symbol.svg");
- await expect(img).toHaveAttribute("alt", "");
- expect(await img.evaluate((el) => (el as HTMLImageElement).naturalWidth)).toBeGreaterThan(0);
- // Last in the row (the footer has more than one list; pick the one that
- // holds the mark).
- const row = footer.locator("ul:has(a[aria-label='Ko-fi'])");
- await expect(row).toHaveCount(1);
- await expect(row.locator("li").last().locator("a[aria-label='Ko-fi']")).toHaveCount(1);
- // No other Ko-fi link anywhere on the page.
- await expect(page.locator(`a[href="${KOFI_URL}"]`)).toHaveCount(1);
+test("the home page has no link to ko-fi.com", async ({ page }) => {
+ await expect(page.locator("footer")).toBeVisible();
+ await expect(page.locator('a[href*="ko-fi.com"]')).toHaveCount(0);
});
test("branded 404 for an unknown path", async ({ page }) => {
diff --git a/homepage/public/kofi-symbol.svg b/homepage/public/kofi-symbol.svg
@@ -1,13 +0,0 @@
-<svg width="241" height="194" viewBox="0 0 241 194" fill="none" xmlns="http://www.w3.org/2000/svg">
-<mask id="mask0_1_219" style="mask-type:luminance" maskUnits="userSpaceOnUse" x="-1" y="0" width="242" height="194">
-<path d="M240.469 0.958984H-0.00585938V193.918H240.469V0.958984Z" fill="white"/>
-</mask>
-<g mask="url(#mask0_1_219)">
-<path d="M96.1344 193.911C61.1312 193.911 32.6597 178.256 15.9721 149.829C1.19788 124.912 -0.00585938 97.9229 -0.00585938 67.7662C-0.00585938 49.8876 5.37293 34.3215 15.5413 22.7466C24.8861 12.1157 38.1271 5.22907 52.8317 3.35378C70.2858 1.14271 91.9848 0.958984 114.545 0.958984C151.259 0.958984 161.63 1.4088 176.075 2.85328C195.29 4.76026 211.458 11.932 222.824 23.5955C234.368 35.4428 240.469 51.2624 240.469 69.3627V72.9994C240.469 103.885 219.821 129.733 191.046 136.759C188.898 141.827 186.237 146.871 183.089 151.837L183.006 151.964C172.869 167.632 149.042 193.918 103.401 193.918H96.1281L96.1344 193.911Z" fill="white"/>
-<path d="M174.568 17.9772C160.927 16.6151 151.38 16.1589 114.552 16.1589C90.908 16.1589 70.9008 16.387 54.7644 18.4334C33.3949 21.164 15.2058 37.5285 15.2058 67.7674C15.2058 98.0066 16.796 121.422 29.0741 142.107C42.9425 165.751 66.1302 178.707 96.1412 178.707H103.414C140.242 178.707 160.25 159.156 170.253 143.698C174.574 136.874 177.754 130.058 179.801 123.234C205.947 120.96 225.27 99.3624 225.27 72.9941V69.3577C225.27 40.9432 206.631 21.164 174.574 17.9772H174.568Z" fill="white"/>
-<path d="M15.1975 67.7674C15.1975 37.5285 33.3866 21.164 54.7559 18.4334C70.8987 16.387 90.906 16.1589 114.544 16.1589C151.372 16.1589 160.919 16.6151 174.559 17.9772C206.617 21.1576 225.255 40.937 225.255 69.3577V72.9941C225.255 99.3687 205.932 120.966 179.786 123.234C177.74 130.058 174.559 136.874 170.238 143.698C160.235 159.156 140.228 178.707 103.4 178.707H96.1264C66.1155 178.707 42.9277 165.751 29.0595 142.107C16.7814 121.422 15.1912 98.4563 15.1912 67.7674" fill="#202020"/>
-<path d="M32.2469 67.9899C32.2469 97.3168 34.0654 116.184 43.6127 133.689C54.5225 153.924 74.3018 161.653 96.8117 161.653H103.857C133.411 161.653 147.736 147.329 155.693 134.829C159.558 128.462 162.966 121.417 164.784 112.547L166.147 106.864H174.332C192.521 106.864 208.208 92.09 208.208 73.2166V69.8082C208.208 48.6669 195.024 37.5228 172.058 34.7987C159.102 33.6646 151.372 33.2084 114.538 33.2084C89.7602 33.2084 72.0272 33.4364 58.6152 35.4828C39.7483 38.2134 32.2407 48.8951 32.2407 67.9899" fill="white"/>
-<path d="M166.158 83.6801C166.158 86.4107 168.204 88.4572 171.841 88.4572C183.435 88.4572 189.802 81.8619 189.802 70.9523C189.802 60.0427 183.435 53.2195 171.841 53.2195C168.204 53.2195 166.158 55.2657 166.158 57.9963V83.6866V83.6801Z" fill="#202020"/>
-<path d="M54.5321 82.3198C54.5321 95.732 62.0332 107.326 71.5807 116.424C77.9478 122.562 87.9515 128.93 94.7685 133.022C96.8147 134.157 98.8611 134.841 101.136 134.841C103.866 134.841 106.134 134.157 107.959 133.022C114.782 128.93 124.779 122.562 130.919 116.424C140.694 107.332 148.195 95.7383 148.195 82.3198C148.195 67.7673 137.286 54.8115 121.599 54.8115C112.28 54.8115 105.912 59.5882 101.136 66.1772C96.8147 59.582 90.2259 54.8115 80.9001 54.8115C64.9855 54.8115 54.5256 67.7673 54.5256 82.3198" fill="#FF5A16"/>
-</g>
-</svg>
