commit 390024e2b67eb08797e96cea31d0b0546f27d067
parent cee2a55f7b3d1c7cee0cf506ab983e69f4c7b3cb
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Thu, 17 Sep 2026 15:08:15 -0400
e2e: lstat the link, never stat it — a dangling link is the whole breakage
The spec asserted the symlink was still there with pathExists, which stats
and therefore FOLLOWS it. With the target moved to the other mountpoint that
reads "no data/ at all" — exactly the misreading common/lib/channelMedia.ts
exists to stop anybody making, reproduced in the test that checks it. readlink
says what is actually true: the link is intact and names a path that is gone.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Diffstat:
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/editor/e2e/storage-locations.spec.ts b/editor/e2e/storage-locations.spec.ts
@@ -3,7 +3,6 @@ import { join } from "node:path";
import { test, expect, type Page } from "@playwright/test";
import { baseUrl } from "./baseUrl";
import {
- pathExists,
readJson,
resetData,
resolvePath,
@@ -221,7 +220,11 @@ test("a volume that came up somewhere else is re-pointed in one click", async ({
mounts: [{ uuid: UUID, target: rootB, fstype: "ext4", label: "platter" }],
fstab: [],
});
- expect(await pathExists(`test-transcripts/channels/${SLUG}/data`)).toBe(true);
+ // The corpus still points at the OLD mountpoint — lstat, never stat: the link
+ // is intact and its target is gone, which is the whole of the breakage. A
+ // stat here follows the link and reports "no data/ at all", which is the
+ // reading this module exists to stop anybody making.
+ expect(await readlink(dataLink())).toBe(targetA);
await page.goto("/storage");
// The probe memo is ten seconds wide and keyed by id+root, neither of which
