commit 252d800c66ad24ee70ddc0af2fefce30fee9768e
parent 51f86a9d94361bf8aed95e7b982e5d4145fb6b51
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Fri, 11 Sep 2026 20:25:10 -0400
plans: 528/528 at the follow-up tip, and the two flakes are named
The suite is green at `51f86a9`. An earlier run of it was 526/528 and both
failures are recorded rather than waved off: an `EEXIST` inside `resetData`'s
`cp` (harness filesystem race, 3/3 on re-run) and `backfill.spec.ts:457`'s
`uncheck()` losing to the `PolicyTreeEditor` adopt-effect — 1 failure in 6 runs
at this sha, 0 in 9 at `4444457`, and green in the full run. Its payload path
for a default priority document is unchanged by this branch, so it reads as the
known adopt race; the sample is small and the note says so.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Diffstat:
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/plans/STATE.md b/plans/STATE.md
@@ -186,11 +186,21 @@ is [`channel-priority.md`](channel-priority.md)'s "as shipped".
- **`excludeFromSync` is deleted** — field, sanitizer clause, action, toggle, and all five
legacy reads. `excludeFromBuild`/`excludeFromCleanup` untouched.
-**The full editor suite at `305fd7b`: 527 passed, 0 failed of 527, 24.5 min** from this
-worktree behind the queue lock (518 + the 9 new priority cases). Two specs went red on the
-way and both were right: `channel-priority.spec.ts:172` caught End focus leaving a stale
-`prio-focus` at the head of the stored tree, and `new-channel-onboarding.spec.ts:111` was
-still reading "Add to top of auto-queue" as a hand-written leaf.
+**The full editor suite at `a8e908a`: 528 passed, 0 failed of 528, 22.9 min** from this
+worktree behind the queue lock (518 + the 10 new priority cases). Three specs went red on
+the way and all three were right: `channel-priority.spec.ts:172` caught End focus leaving a
+stale `prio-focus` at the head of the stored tree, and `new-channel-onboarding.spec.ts:111`
+was still reading "Add to top of auto-queue" as a hand-written leaf.
+
+**Two flakes cost a suite run and are named so the next session does not re-chase them.** An
+earlier run at `a8e908a` was 526/528: `no-subs-fallback.spec.ts:114` failed on an `EEXIST`
+inside `resetData`'s `cp` (a filesystem race in the harness, 3/3 green on re-run), and
+`backfill.spec.ts:457` failed on `uncheck()` not changing a controlled checkbox — the
+`PolicyTreeEditor` adopt-effect race, where the 3 s status poll calls `setForm` between the
+click and its assertion. Measured after: 1 failure in 6 runs of that case at `a8e908a`, 0 in
+9 at `4d256a2`, and the clean 528/528 above. Its payload path for a DEFAULT priority
+document is unchanged by this branch, so it reads as the known adopt race rather than a
+regression — but the sample is small, and it is the case to look at first if it recurs.
**⚠ THE MIGRATION MUST RUN BEFORE THE FIRST BOOT OF THIS CODE, not after it.**
`excludeFromSync` is deleted and `parseChannelConfig` drops the key, so on a corpus that has
diff --git a/plans/channel-priority.md b/plans/channel-priority.md
@@ -538,7 +538,9 @@ S1–S4 merged into S5 in order with **no conflicts** — the graph's disjoint-f
exactly. S5's own commits: the duplication fold (`7e3b282`), the keep decision (`13c5da4`),
dense ranks and idempotence (`8c335d5`), one writer of `root` plus the legacy seed
(`a5bb23f`), the seeding e2e (`a12aa14`), the migration script (`278e648`), the deletion of
-`excludeFromSync` (`dca3109`), the End-focus recompile (`d487519`), the records and the onboarding spec (`305fd7b`).
+`excludeFromSync` (`dca3109`), the End-focus recompile (`d487519`), the records, the onboarding spec (`305fd7b`) and the
+review's three should-fixes (`a8e908a`: the rename writer, the migration's own backup, the
+rollout warning).
### Divergences from the plan
@@ -593,7 +595,7 @@ link is the way to everything else the document says.
`pnpm --filter yt-dlp-transcript-common test`: **985 passed** (974 at the merge — 951 + S1's
11 + S2's 12 — plus 6 `laneDispatchRoot`/`priorityContextFor` cases, 4 `decideKeep` cases and
1 idempotence case).
-**Full editor e2e at `305fd7b`: 527 passed, 0 failed, 24.5 min.**
+**Full editor e2e at `a8e908a`: 528 passed, 0 failed, 22.9 min.**
### The live migration, dry-run
