commit 189b3cd10146525a5058683d044849bc320aafbf
parent 6005588cd9bedea718abc2ff9e35b7c06d86f73f
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Mon, 28 Sep 2026 04:34:58 -0400
plans: O6 checkpoint B review fixes — the 2origin note corrected with the reviewer's evidence (S1), L1, L2 recorded
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Diffstat:
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/plans/release-11.md b/plans/release-11.md
@@ -1478,12 +1478,36 @@ and `o6-gB-*.log`.
- a drifting port fallback in `baseUrl.ts` fails `ports.test` (1).
**Found and left (checkpoint B):**
-- `e2e:2origin` was not run. Its config's ports and declaration changed, and its setup renames
- `E2E_TWO_ORIGIN_REBUILD`. But a rebuild runs `pnpm run build:hub`, whose compose writes into
- `export/public`, and in a worktree that is symlinks into the primary checkout (the release-7
- lesson). Run it from the primary, or with `export/public` de-linked first.
+- **`e2e:2origin` was run by the reviewer, not by me** *(corrected after review S1; the first
+ version of this bullet was wrong)*. Its config's ports and declaration changed, and its setup
+ reads the renamed `E2E_TWO_ORIGIN_REBUILD`.
+ - The reviewer ran `E2E_TWO_ORIGIN_REBUILD=1 node scripts/worktree.mjs run -- pnpm --filter
+ export run e2e:2origin` in this worktree: **3 passed** (34.3 s), the hub rebuilt.
+ - The primary's `export/public` was byte-identical before and after: all 380 files matched on
+ path, type, size, mtime and md5 (`$T/o6b-rv-{before,after}.{meta,md5}`).
+ - Why: compose-hub writes through `writePublicFile`, which removes the path first and so never
+ writes through a link, and `sw.js` / `hub-summary.json` are `rm`'d, which removes the link
+ only. I had claimed the opposite.
+ - The run leaves this worktree's `export/public` with real files where links were; they were
+ re-linked afterwards (review L2).
+ - Never run it from the primary checkout: there the entries are real files, and `build:hub`
+ would overwrite the live hub files with an empty pool (the release-7 accident).
- Old names survive only in `plans/` and released changelog text.
+**Review fixes (checkpoint B)** — the review (`o6b-review.md`) was SHIP AFTER FIXES, with no
+blocker. Docs and record only:
+- **S1:** the `e2e:2origin` bullet above is corrected with the reviewer's run and evidence. The
+ "run it from the primary" advice is deleted here and in the report; it would have repeated the
+ release-7 accident.
+- **L1** (the commit just before this record's): WORKTREES.md now says a server reused under
+ `E2E_PORT_CHECK=0` must be started with the config's `E2E_SERVER_ENV` values.
+- **L2:** the reviewer's 2origin run left real files where this worktree's `export/public` links
+ were: `corpus.json`, `_headers`, `hub-sites.json`, `llms.txt`, `robots.txt` and `sw.js`, and
+ `hub-summary.json` was removed. All were re-linked from the primary with the implementer-rules
+ loop, in the worktree only. `find export/public -xtype l` is empty.
+- **N1** (pre-existing, recorded only): with `E2E_TWO_ORIGIN_REBUILD=1`, playwright loads
+ `playwright.2origin.config.ts` twice, so `stageTwoOrigins()` builds the hub twice per run.
+
## Rollout
Nothing is rolled out tonight. The morning runbook lists what is owed: the :3001 editor restart,
