commit 0b3a3c5f4fb54828d17f2fcf6dc1698729ef1812
parent c62b9c5e3e2a2d7c980bbd8c2c1c9cfaa825185f
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Tue, 8 Sep 2026 00:32:41 -0400
editor: the one spec that asserted the backfill checkbox by its retired field
`operation-settings.spec.ts:104` proved that saving the diarization form beside
the lane form does not clear the lane's switch, and it proved it by reading
`backfill.enabled` — which the checkbox stopped writing when the gate moved onto
`autoQueue.backfill.held`. The property is unchanged and so is the click; only
the key it reads back moves, and checked now means `held: false`. Caught by the
full e2e run, which is what that run is for.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Diffstat:
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/editor/e2e/backfill.spec.ts b/editor/e2e/backfill.spec.ts
@@ -766,13 +766,13 @@ test("the diarization page shows the channel and both populations", async ({
// PAUSE IS A HOLD, NOT A STOP, and it is reachable from where the work is
// watched. The hold has always existed — the backfill lane's limit() re-reads
-// settings.backfill.enabled at dispatch and returns 0, so the pool idle-waits
-// and the job keeps its place — but the only way to set it was the Settings
-// page, which is a strange place to look for a control over a job you are
-// watching run on the dashboard.
+// the lane's gate at dispatch and returns 0, so the pool idle-waits and the job
+// keeps its place — but the only way to set it was the Settings page, which is
+// a strange place to look for a control over a job you are watching run on the
+// dashboard.
//
-// The button writes THE SAME FIELD as that checkbox rather than a second
-// `backfillPaused` flag, so the two cannot drift; this asserts the field,
+// The button writes THE SAME KEY as that checkbox rather than a second
+// `backfillPaused` flag, so the two cannot drift; this asserts the key,
// not just the label, for exactly that reason. It also asserts the button
// renders WITHOUT a sweep armed — an operator pauses a hand-clicked
// backfill-channel job too, not only an armed lane.
diff --git a/editor/e2e/operation-settings.spec.ts b/editor/e2e/operation-settings.spec.ts
@@ -125,11 +125,16 @@ test("the lane's switch survives a save of the operation form beside it", async
.click();
await expect(diarization.getByRole("status")).toHaveText("Saved.");
+ // "Run the backfill lane" IS the lane's gate, and since slice 1.4 the gate is
+ // `autoQueue.backfill.held` — checked means running, so held is false. It used
+ // to write the inverted `backfill.enabled`; that field is the migration's
+ // input now and nothing writes it, so asserting it here would assert a value
+ // no click can move.
const saved = await readJson<{
- backfill?: { enabled: boolean };
+ autoQueue?: { backfill?: { held?: boolean } };
diarization?: { enabled: boolean };
}>("test-settings.json");
- expect(saved.backfill?.enabled).toBe(true);
+ expect(saved.autoQueue?.backfill?.held).toBe(false);
expect(saved.diarization?.enabled).toBe(true);
});
