commit 6005588cd9bedea718abc2ff9e35b7c06d86f73f
parent 980196abe0efa9b4fc2e07524bedeee3b483ca87
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Mon, 28 Sep 2026 04:34:58 -0400
docs: WORKTREES — a server reused under E2E_PORT_CHECK=0 needs the config's E2E_SERVER_ENV (review L1)
Since checkpoint B moved E2E_TEST_ROUTES and the audio-check knobs out of
dev:test / start:test into editor/playwright.config.ts, a hand-started
`pnpm dev:test` has neither: under E2E_PORT_CHECK=0 its /api/test/* answers
404 and the audio checks run at production pace. The trade-off paragraph
spells out the env to start it with, and the escape-hatch row points there.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Diffstat:
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/WORKTREES.md b/WORKTREES.md
@@ -129,14 +129,20 @@ lock at that moment, no *queued* run can own those ports: what you are looking a
leftover from a killed run, or a server someone started by hand.
The trade-off: a hand-started `pnpm dev:test` on 3011 is no longer silently reused, so the
-~30s server boot is no longer skippable. `E2E_PORT_CHECK=0` restores the old behavior.
+~30s server boot is no longer skippable. `E2E_PORT_CHECK=0` restores the old behavior — but a
+reused server must then be started with the test-only env that `editor/playwright.config.ts`'s
+`E2E_SERVER_ENV` gives the servers Playwright starts (`E2E_TEST_ROUTES=1
+E2E_AUDIO_CHECK_INTERVAL_MS=300 E2E_AUDIO_CHECK_SIZE_GATE=4096
+E2E_AUDIO_CHECK_INTERVAL_FLOOR_MS=50 E2E_AUDIO_CHECK_RECOVER_STEP_MS=100
+E2E_AUDIO_CHECK_RECOVER_AFTER=2 pnpm dev:test`). Without it `/api/test/*` answers 404 and the
+audio checks run at production pace, which reads as real failures.
### Escape hatches
| Variable | Effect |
|---|---|
| `E2E_QUEUE=0` | Skip the queue entirely (the port preflight still runs) |
-| `E2E_PORT_CHECK=0` | Skip the port preflight, reusing whatever servers are up |
+| `E2E_PORT_CHECK=0` | Skip the port preflight, reusing whatever servers are up (a hand-started editor test server needs the config's `E2E_SERVER_ENV`, above) |
| `E2E_QUEUE_TIMEOUT=<seconds>` | Give up waiting after N seconds (default: wait forever) |
Verify the queue with `pnpm test:scripts`.