archilyzer

commit 2b59eb9c7208600a27c3edc3b7579a4af85ac5a8
parent 949edfe0b22e26420fca1b6f4713380756adafba
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date:   Tue,  4 Aug 2026 22:55:39 -0400

Don't generate a report in the rename spec — it blocks the rename

The blanket e2e migration onto generateReport() was too broad here.
renameChannelAction refuses while the channel has running or queued jobs, and
generateReport queues a refresh-report job — so the rename silently declined
and the test failed on the post-redirect URL assertion.

This spec never needed a report: since the channel page stopped generating one
inside a GET, it renders perfectly well without one (empty buckets plus a
banner). Removing the call is the fix, and the comment says why so it doesn't
get added back.

Checked the other specs for the same conflict: rename is the only action that
blocks on active jobs, so channels.spec's delete flow is unaffected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Diffstat:
M
editor/e2e/channel-rename.spec.ts
 | 
7
+++++--

1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/editor/e2e/channel-rename.spec.ts b/editor/e2e/channel-rename.spec.ts
@@ -1,5 +1,5 @@
 import { test, expect } from "@playwright/test";
-import { readJson, resetData, writeSite, generateReport } from "./helpers";
+import { readJson, resetData, writeSite } from "./helpers";
 
 // Renaming a channel's slug lives in the Danger zone and requires typing the
 // current slug to confirm (mirroring delete). On success it migrates slug-keyed
@@ -15,7 +15,10 @@ test("rename requires the exact current slug and then moves the channel", async 
   // A site that lists the channel — its membership must follow the rename.
   await writeSite("mysite", { channels: [{ slug: OLD }] });
 
-  await generateReport(page, OLD);
+  // Deliberately NO generateReport here: it queues a refresh-report job, and
+  // renaming refuses while any job for the channel is active. This test doesn't
+  // need a report — the channel page renders fine without one (empty buckets
+  // plus a banner), which is the whole point of not generating inside a GET.
   await page.goto(`/channels/${OLD}`);
 
   const newSlug = page.getByLabel("new slug");