commit 1410ca0b04021d4692b684a2e944724d80eb9ba5
parent d0486c255376a29ba73e99c1b7e2b0ba2fd9f3fd
Author: I Mean I'm Just Saying <imeanimjustsaying@kiwifarms.st>
Date: Mon, 28 Sep 2026 04:03:11 -0400
editor: the build-mode options and the per-site panel say the mode is a label (R2/R6 re-read nits)
Settings' Build mode options read "Basic (a label for now)" / "Docker (a
label for now)" instead of "serial build queue" / "isolated parallel
builds". The per-site batch panel's note is shown whatever the mode (it is
true in both), so its `serial` prop goes; /sites' Build all sentence no
longer says "(Docker mode)" and its comment no longer says the mode decides
the fan-out. Copy only.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Diffstat:
4 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/editor/app/settings/components/SettingsForm.tsx b/editor/app/settings/components/SettingsForm.tsx
@@ -316,8 +316,8 @@ export function SettingsForm({ initial }: Props) {
defaultValue={initial.buildPipeline.mode}
className="rounded border border-border bg-card px-2 py-1 text-sm"
>
- <option value="basic">Basic — serial build queue</option>
- <option value="docker">Docker — isolated parallel builds</option>
+ <option value="basic">Basic (a label for now)</option>
+ <option value="docker">Docker (a label for now)</option>
</select>
</label>
<Field
diff --git a/editor/app/sites/components/BuildSitesPanel.tsx b/editor/app/sites/components/BuildSitesPanel.tsx
@@ -16,13 +16,7 @@ type Lane = { siteId: string; title: string; deploy: boolean; key: string };
// launches its own managed job, rendered as its own live JobLane. The jobs share
// the build/deploy queue and run one at a time (the export/ tree is shared),
// whichever build mode is set; "Build all sites" is the parallel path.
-export function BuildSitesPanel({
- sites,
- serial,
-}: {
- sites: SiteOption[];
- serial: boolean;
-}) {
+export function BuildSitesPanel({ sites }: { sites: SiteOption[] }) {
const [selected, setSelected] = useState<Set<string>>(new Set());
const [deployAfter, setDeployAfter] = useState(false);
const [lanes, setLanes] = useState<Lane[] | null>(null);
@@ -125,13 +119,11 @@ export function BuildSitesPanel({
only (deploy is skipped for them).
</p>
)}
- {serial && (
- <p className="text-xs text-muted-foreground">
- These run one at a time (the build output tree is shared). “Build
- all sites” above builds every site in parallel, in containers, whenever
- a container engine answers.
- </p>
- )}
+ <p className="text-xs text-muted-foreground">
+ These run one at a time (the build output tree is shared), whichever
+ build mode is set. “Build all sites” above builds every site in
+ parallel, in containers, whenever a container engine answers.
+ </p>
{lanes && lanes.length > 0 && (
<div className="flex flex-col gap-2">
diff --git a/editor/app/sites/page.tsx b/editor/app/sites/page.tsx
@@ -160,14 +160,16 @@ export default async function SitesPage() {
/>
</section>
- {/* Batch: build (and optionally deploy) several sites at once. The mode
- decides whether the batch fans out, so it is set here beside it. */}
+ {/* Batch: build (and optionally deploy) several sites at once. The
+ build mode toggle sits here, and says it is a label: Build all fans
+ out in containers whenever an engine answers, whatever it says. */}
<section className="flex flex-col gap-3 border-t border-border pt-6">
<div>
<h2 className="text-lg font-semibold">Build all sites</h2>
<p className="text-sm text-muted-foreground">
One job over every site: the shared data phase runs once, per-site
- builds run in parallel (Docker mode), then deploys run serially.
+ builds run in parallel in containers (when a container engine
+ answers), then deploys run serially.
</p>
</div>
<BuildModeToggle mode={buildMode} />
@@ -186,7 +188,6 @@ export default async function SitesPage() {
siteTitle: s.siteTitle,
cloudflareProject: s.cloudflareProject ?? null,
}))}
- serial={buildMode === "basic"}
/>
</section>
diff --git a/editor/e2e/deploy-page.spec.ts b/editor/e2e/deploy-page.spec.ts
@@ -149,6 +149,6 @@ test("batch panel: selecting sites enables the launch button and reflects deploy
page.getByRole("button", { name: "Build & deploy selected" }),
).toBeVisible();
- // Basic mode (the default) notes that the batch runs serially.
+ // The panel notes that the batch runs serially, whatever the mode.
await expect(page.getByText(/These run one at a time/i)).toBeVisible();
});
